linux-kernel - Re: [PATCH] char: hw_random: bcm2835-rng: removed call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH3L5QphsxcYC7=FK1=MEYcE-VyFy9t60jS8MZ_9TA5SMKTibg@mail.gmail.com>
Date:   Thu, 24 Aug 2023 11:25:47 +0300
From:   Alexandru Ardelean <alex@...uggie.ro>
To:     Martin Kaiser <lists@...ser.cx>
Cc:     Andrei Coardos <aboutphysycs@...il.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org, linux-crypto@...r.kernel.org,
        Jason@...c4.com, bcm-kernel-feedback-list@...adcom.com,
        sbranden@...adcom.com, rjui@...adcom.com,
        florian.fainelli@...adcom.com, herbert@...dor.apana.org.au,
        olivia@...enic.com
Subject: Re: [PATCH] char: hw_random: bcm2835-rng: removed call to platform_set_drvdata()

On Wed, Aug 23, 2023 at 2:59 PM Martin Kaiser <lists@...ser.cx> wrote:
>
> Andrei Coardos (aboutphysycs@...il.com) wrote:
>
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver. Also,
> > the private data is defined in this driver, so there is no risk of it being
> > accessed outside of this driver file.
>
> You're right. The platform_get_drvdata call was removed in
> 4c04b3729 ("hwrng: bcm2835 - Use device managed helpers").
>

Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>

> Reviewed-by: Martin Kaiser <martin@...ser.cx>