linux-kernel - Re: [PATCH] char: hw_random: hisi-rng: removed unneeded call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH3L5QpmVqNMr_kSFa_rar5ZEjLv_5Xxjss4syVX2_0bCuL5vQ@mail.gmail.com>
Date:   Thu, 24 Aug 2023 11:28:00 +0300
From:   Alexandru Ardelean <alex@...uggie.ro>
To:     Martin Kaiser <lists@...ser.cx>
Cc:     Andrei Coardos <aboutphysycs@...il.com>,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        herbert@...dor.apana.org.au, olivia@...enic.com
Subject: Re: [PATCH] char: hw_random: hisi-rng: removed unneeded call to platform_set_drvdata()

On Wed, Aug 23, 2023 at 4:44 PM Martin Kaiser <lists@...ser.cx> wrote:
>
> Andrei Coardos (aboutphysycs@...il.com) wrote:
>
> > This function call was found to be unnecessary as there is no equivalent
> > platform_get_drvdata() call to access the private data of the driver. Also,
> > the private data is defined in this driver, so there is no risk of it being
> > accessed outside of this driver file.
>
> > Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> > ---
> >  drivers/char/hw_random/hisi-rng.c | 2 --
> >  1 file changed, 2 deletions(-)
>
> > diff --git a/drivers/char/hw_random/hisi-rng.c b/drivers/char/hw_random/hisi-rng.c
> > index 96438f85cafa..b6f27566e0ba 100644
> > --- a/drivers/char/hw_random/hisi-rng.c
> > +++ b/drivers/char/hw_random/hisi-rng.c
> > @@ -79,8 +79,6 @@ static int hisi_rng_probe(struct platform_device *pdev)
> >       if (!rng)
> >               return -ENOMEM;
>
> > -     platform_set_drvdata(pdev, rng);
> > -
> >       rng->base = devm_platform_ioremap_resource(pdev, 0);
> >       if (IS_ERR(rng->base))
> >               return PTR_ERR(rng->base);
> > --
> > 2.34.1
>
> This one can go.
>

Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>

> Reviewed-by: Martin Kaiser <martin@...ser.cx>