linux-kernel - Re: [PATCH v5 3/3] mmc: atmel-mci: Move card detect gpio polarity quirk to gpiolib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY83_nQx8tWRV9SJyD=-SvY+30FiSXkrb5vKkd+QfuPaA@mail.gmail.com>
Date:   Thu, 24 Aug 2023 10:33:56 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Balamanikandan.Gunasundar@...rochip.com
Cc:     dmitry.torokhov@...il.com, ulf.hansson@...aro.org,
        linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Ludovic.Desroches@...rochip.com, Nicolas.Ferre@...rochip.com,
        alexandre.belloni@...tlin.com, Hari.PrasathGE@...rochip.com
Subject: Re: [PATCH v5 3/3] mmc: atmel-mci: Move card detect gpio polarity
 quirk to gpiolib

On Thu, Aug 24, 2023 at 8:39 AM <Balamanikandan.Gunasundar@...rochip.com> wrote:

> >> +#if IS_ENABLED(CONFIG_MMC_ATMELMCI)
> >> +       if (of_device_is_compatible(np->parent, "atmel,hsmci") &&
>
> The only difference above is "np->parent" while the existing code uses
> "np". This is because the compatible string is defined in the parent
> node here while the others have it in the same node.

Aha. What about this right before the for-loop
then:

/* The Atmel MSMCI has the property in a child node of the device */
if (IS_ENABLED(CONFIG_MMC_ATMELMCI) &&
of_device_is_compatible(np->parent, "atmel,hsmci"))
  np = parent->np;

Yours,
Linus Walleij