linux-kernel - Re: [PATCH] ARM: dts: at91: ksz9477_evb: Add tx-internal-delay-ps property for port5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230824111702.1a034801@wsk>
Date:   Thu, 24 Aug 2023 11:17:02 +0200
From:   Lukasz Majewski <lukma@...x.de>
To:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>
Cc:     Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: at91: ksz9477_evb: Add tx-internal-delay-ps
 property for port5

Dear Community,

> Without this change the KSZ9477 Evaluation board's Linux (v6.5-rc1)
> shows following device warning:
> 
> 'ksz-switch spi1.0: Port 5 interpreting RGMII delay settings based on
> "phy-mode" property, please update device tree to specify
> "rx-internal-delay-ps" and "tx-internal-delay-ps"'
> 
> This is not critical, as KSZ driver by itself assigns default value of
> tx delay to 2000 ps (as 'rgmii-txid' is set as PHY mode).
> 
> However, to avoid extra warnings in logs - the missing
> 'tx-internal-delay-ps' has been specified with the default value of
> 2000 ps.
> 

Gentle ping on this patch.

Claudiu, could you pick it as well?

> Signed-off-by: Lukasz Majewski <lukma@...x.de>
> ---
>  arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts
> b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts index
> 99cd6d15998b..b66570080894 100644 ---
> a/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts +++
> b/arch/arm/boot/dts/microchip/at91-sama5d3_ksz9477_evb.dts @@ -152,6
> +152,7 @@ label = "cpu";
>  				ethernet = <&macb0>;
>  				phy-mode = "rgmii-txid";
> +				tx-internal-delay-ps = <2000>;
>  
>  				fixed-link {
>  					speed = <1000>;

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@...x.de

Content of type "application/pgp-signature" skipped