linux-kernel - Re: [PATCH] ceph: Remove duplicate include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOi1vP-7eC9WALP=fiQ_VPv8D0aPAMJS45WYwxRWSKaTB3Cv7Q@mail.gmail.com>
Date:   Thu, 24 Aug 2023 11:29:10 +0200
From:   Ilya Dryomov <idryomov@...il.com>
To:     Xiubo Li <xiubli@...hat.com>
Cc:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        jlayton@...nel.org, ceph-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] ceph: Remove duplicate include

On Thu, Aug 24, 2023 at 10:18 AM Xiubo Li <xiubli@...hat.com> wrote:
>
>
> On 8/24/23 15:54, Jiapeng Chong wrote:
> > ./fs/ceph/mds_client.c: crypto.h is included more than once.
> >
> > Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6211
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> > ---
> >   fs/ceph/mds_client.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> > index 7cfa0e3aedb4..9a3b617270c3 100644
> > --- a/fs/ceph/mds_client.c
> > +++ b/fs/ceph/mds_client.c
> > @@ -16,7 +16,6 @@
> >   #include "super.h"
> >   #include "crypto.h"
> >   #include "mds_client.h"
> > -#include "crypto.h"
> >
> >   #include <linux/ceph/ceph_features.h>
> >   #include <linux/ceph/messenger.h>
>
> Reviewed-by: Xiubo Li <xiubli@...hat.com>

I folded the fix into "ceph: encode encrypted name in
ceph_mdsc_build_path and dentry release" commit.  Thanks for
the report!

                Ilya