linux-kernel - Re: [PATCH v5 13/45] quota: dynamically allocate the dquota-cache shrinker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230824095139.nvdozxopqq65yiln@quack3>
Date:   Thu, 24 Aug 2023 11:51:39 +0200
From:   Jan Kara <jack@...e.cz>
To:     Qi Zheng <zhengqi.arch@...edance.com>
Cc:     akpm@...ux-foundation.org, david@...morbit.com, tkhai@...ru,
        vbabka@...e.cz, roman.gushchin@...ux.dev, djwong@...nel.org,
        brauner@...nel.org, paulmck@...nel.org, tytso@....edu,
        steven.price@....com, cel@...nel.org, senozhatsky@...omium.org,
        yujie.liu@...el.com, gregkh@...uxfoundation.org,
        muchun.song@...ux.dev, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, linux-fsdevel@...r.kernel.org,
        Muchun Song <songmuchun@...edance.com>,
        Jan Kara <jack@...e.com>
Subject: Re: [PATCH v5 13/45] quota: dynamically allocate the dquota-cache
 shrinker

On Thu 24-08-23 11:42:32, Qi Zheng wrote:
> Use new APIs to dynamically allocate the dquota-cache shrinker.
> 
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>
> Reviewed-by: Muchun Song <songmuchun@...edance.com>
> CC: Jan Kara <jack@...e.com>

Looks good to me. Feel free to add:

Acked-by: Jan Kara <jack@...e.cz>

								Honza



> ---
>  fs/quota/dquot.c | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
> index 9e72bfe8bbad..c303cffdf433 100644
> --- a/fs/quota/dquot.c
> +++ b/fs/quota/dquot.c
> @@ -791,12 +791,6 @@ dqcache_shrink_count(struct shrinker *shrink, struct shrink_control *sc)
>  	percpu_counter_read_positive(&dqstats.counter[DQST_FREE_DQUOTS]));
>  }
>  
> -static struct shrinker dqcache_shrinker = {
> -	.count_objects = dqcache_shrink_count,
> -	.scan_objects = dqcache_shrink_scan,
> -	.seeks = DEFAULT_SEEKS,
> -};
> -
>  /*
>   * Safely release dquot and put reference to dquot.
>   */
> @@ -2956,6 +2950,7 @@ static int __init dquot_init(void)
>  {
>  	int i, ret;
>  	unsigned long nr_hash, order;
> +	struct shrinker *dqcache_shrinker;
>  
>  	printk(KERN_NOTICE "VFS: Disk quotas %s\n", __DQUOT_VERSION__);
>  
> @@ -2990,8 +2985,15 @@ static int __init dquot_init(void)
>  	pr_info("VFS: Dquot-cache hash table entries: %ld (order %ld,"
>  		" %ld bytes)\n", nr_hash, order, (PAGE_SIZE << order));
>  
> -	if (register_shrinker(&dqcache_shrinker, "dquota-cache"))
> -		panic("Cannot register dquot shrinker");
> +	dqcache_shrinker = shrinker_alloc(0, "dquota-cache");
> +	if (!dqcache_shrinker)
> +		panic("Cannot allocate dquot shrinker");
> +
> +	dqcache_shrinker->count_objects = dqcache_shrink_count;
> +	dqcache_shrinker->scan_objects = dqcache_shrink_scan;
> +	dqcache_shrinker->seeks = DEFAULT_SEEKS;
> +
> +	shrinker_register(dqcache_shrinker);
>  
>  	return 0;
>  }
> -- 
> 2.30.2
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR