linux-kernel - Re: [PATCH v4 5/7] drm/vkms: Support enabling ConfigFS devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202308241907.YtPY7t8j-lkp@intel.com>
Date:   Thu, 24 Aug 2023 19:13:55 +0800
From:   kernel test robot <lkp@...el.com>
To:     Brandon Pollack <brpol@...omium.org>, marius.vlad@...labora.com,
        jshargo@...omium.org
Cc:     oe-kbuild-all@...ts.linux.dev, hamohammed.sa@...il.com,
        rodrigosiqueiramelo@...il.com, linux-doc@...r.kernel.org,
        hirono@...omium.org, mduggan@...omium.org, corbet@....net,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        melissa.srw@...il.com, mairacanal@...eup.net, mripard@...nel.org,
        tzimmermann@...e.de, Brandon Pollack <brpol@...omium.org>
Subject: Re: [PATCH v4 5/7] drm/vkms: Support enabling ConfigFS devices

Hi Brandon,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on next-20230824]
[cannot apply to linus/master v6.5-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Brandon-Pollack/drm-vkms-Back-VKMS-with-DRM-memory-management-instead-of-static-objects/20230824-164550
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20230824084350.1062579-6-brpol%40chromium.org
patch subject: [PATCH v4 5/7] drm/vkms: Support enabling ConfigFS devices
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230824/202308241907.YtPY7t8j-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230824/202308241907.YtPY7t8j-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308241907.YtPY7t8j-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/vkms/vkms_output.c:178: warning: Function parameter or member 'vkmsdev' not described in 'validate_vkms_configfs_no_dangling_objects'


vim +178 drivers/gpu/drm/vkms/vkms_output.c

   166	
   167	/**
   168	* validate_vkms_configfs_no_dangling_objects - warn on unused objects in vkms configfs.
   169	*
   170	* This gives slightly more visible warning messaging to the user before the drm
   171	* system finds the configuration invalid and prints it's debug information.  In
   172	* this case the user may have accidentally not included some links, or the user
   173	* could be testing this faulty configuration.
   174	*
   175	*/
   176	static void
   177	validate_vkms_configfs_no_dangling_objects(struct vkms_device *vkmsdev)
 > 178	{
   179		struct vkms_configfs *configfs = vkmsdev->configfs;
   180		struct config_item *item;
   181	
   182		// 1. Planes
   183		list_for_each_entry(item, &configfs->planes_group.cg_children,
   184				    ci_entry) {
   185			struct vkms_config_plane *config_plane =
   186				item_to_config_plane(item);
   187			if (config_plane->possible_crtcs.linked_object_bitmap == 0)
   188				DRM_WARN(
   189					"Vkms configfs created plane %s has no linked crtcs",
   190					item->ci_name);
   191		}
   192	
   193		// 2. connectors
   194		list_for_each_entry(item, &configfs->connectors_group.cg_children,
   195				    ci_entry) {
   196			struct vkms_config_connector *config_connector =
   197				item_to_config_connector(item);
   198			if (config_connector->possible_encoders.linked_object_bitmap ==
   199			    0) {
   200				DRM_WARN(
   201					"Vkms configfs created connector %s has no linked encoders",
   202					item->ci_name);
   203			}
   204		}
   205	
   206		// 3. encoders
   207		list_for_each_entry(item, &configfs->encoders_group.cg_children,
   208				    ci_entry) {
   209			struct vkms_config_encoder *config_encoder =
   210				item_to_config_encoder(item);
   211			if (config_encoder->possible_crtcs.linked_object_bitmap == 0) {
   212				DRM_WARN(
   213					"Vkms configfs created encoder %s has no linked crtcs",
   214					item->ci_name);
   215			}
   216		}
   217	
   218		// 4. crtcs only require a primary plane to function, this is checked during
   219		// output initialization and returns an error.
   220	}
   221	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki