linux-kernel - Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3c4c781-2f74-4b09-9db4-7b947897ef5a@amd.com>
Date:   Thu, 24 Aug 2023 08:14:26 -0400
From:   Hamza Mahfooz <hamza.mahfooz@....com>
To:     Lee Jones <lee@...nel.org>,
        Jani Nikula <jani.nikula@...ux.intel.com>
Cc:     Karol Herbst <kherbst@...hat.com>, nouveau@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org,
        Mikko Perttunen <mperttunen@...dia.com>,
        Maíra Canal <mairacanal@...eup.net>,
        Thierry Reding <thierry.reding@...il.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Shashank Sharma <shashank.sharma@....com>,
        Michal Simek <michal.simek@...inx.com>,
        amd-gfx@...ts.freedesktop.org,
        Jonathan Hunter <jonathanh@...dia.com>,
        Luben Tuikov <luben.tuikov@....com>,
        Danilo Krummrich <dakr@...hat.com>,
        Ben Skeggs <bskeggs@...hat.com>,
        Stanley Yang <Stanley.Yang@....com>,
        linux-media@...r.kernel.org,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Maxime Ripard <mripard@...nel.org>,
        linaro-mm-sig@...ts.linaro.org, linux-tegra@...r.kernel.org,
        NXP Linux Team <linux-imx@....com>,
        linux-arm-kernel@...ts.infradead.org,
        Hyun Kwon <hyun.kwon@...inx.com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>, linux-kernel@...r.kernel.org,
        Hawking Zhang <Hawking.Zhang@....com>,
        Jerome Glisse <glisse@...edesktop.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Alex Deucher <alexander.deucher@....com>,
        Gourav Samaiya <gsamaiya@...dia.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Christian König <christian.koenig@....com>,
        Mario Limonciello <mario.limonciello@....com>
Subject: Re: [PATCH (set 1) 00/20] Rid W=1 warnings from GPU


On 8/24/23 08:07, Lee Jones wrote:
> On Thu, 24 Aug 2023, Jani Nikula wrote:
> 
>> On Thu, 24 Aug 2023, Lee Jones <lee@...nel.org> wrote:
>>> This set is part of a larger effort attempting to clean-up W=1
>>> kernel builds, which are currently overwhelmingly riddled with
>>> niggly little warnings.
>>
>> The next question is, how do we keep it W=1 clean going forward?
> 
> My plan was to fix them all, then move each warning to W=0.
> 
> Arnd recently submitted a set doing just that for a bunch of them.
> 
> https://lore.kernel.org/all/20230811140327.3754597-1-arnd@kernel.org/
> 
> I like to think a bunch of this is built on top of my previous efforts.
> 
> GPU is a particularly tricky though - the warnings seem to come in faster
> than I can squash them.  Maybe the maintainers can find a way to test
> new patches on merge?

I guess on that note, do you know if there is a way to run
`scripts/kernel-doc` on patches instead of whole files? That would make
much easier to block new kernel-doc issues from appearing.

> 
>> Most people don't use W=1 because it's too noisy, so it's a bit of a
>> catch-22.
>>
>> In i915, we enable a lot of W=1 warnings using subdir-ccflags-y in our
>> Makefile. For CI/developer use we also enable kernel-doc warnings by
>> default.
>>
>> Should we start enabling some of those warning flags in drm/Makefile to
>> to keep the entire subsystem warning free?
> 
> That would we awesome!  We'd just need buy-in.
> 
-- 
Hamza