linux-kernel - Re: [PATCH v8 7/7] iio: accel: Add support for Kionix/ROHM KX132-1211 accelerometer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3c2e506-3840-0136-a28f-a50eb0fdf72d@gmail.com>
Date:   Thu, 24 Aug 2023 15:51:18 +0300
From:   Matti Vaittinen <mazziesaccount@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mehdi Djait <mehdi.djait.k@...il.com>
Cc:     jic23@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        robh+dt@...nel.org, lars@...afoo.de, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v8 7/7] iio: accel: Add support for Kionix/ROHM KX132-1211
 accelerometer

On 8/24/23 15:02, Andy Shevchenko wrote:
> On Wed, Aug 23, 2023 at 11:16:41PM +0200, Mehdi Djait wrote:
>> Kionix KX132-1211 is a tri-axis 16-bit accelerometer that can support
>> ranges from ±2G to ±16G, digital output through I²C/SPI.
>> Add support for basic accelerometer features such as reading acceleration
>> via IIO using raw reads, triggered buffer (data-ready), or the WMI IRQ.
> 
> ...
> 
>>   	help
>> -	  Enable support for the Kionix KX022A digital tri-axis
>> -	  accelerometer connected to I2C interface.
>> +	  Enable support for the Kionix KX022A, KX132-1211 digital tri-axis
>> +	  accelerometers connected to SPI interface.
> 
> I know I have given a tag, but since it most likely require a new version,
> this can be amended for the better maintenance as
> 
> 	  Enable support for the Kionix digital tri-axis accelerometers
> 	  connected to SPI interface. Supported devices are:
> 	    KX022A, KX132-1211
> 
> ...
> 
>>   	help
>> -	  Enable support for the Kionix KX022A digital tri-axis
>> -	  accelerometer connected to I2C interface.
>> +	  Enable support for the Kionix KX022A, KX132-1211 digital tri-axis
>> +	  accelerometers connected to I2C interface.
> 
> Ditto.
> 
> ...
> 
>> +static const struct regmap_access_table kx132_volatile_regs = {
>> +	.yes_ranges = &kx132_volatile_ranges[0],
> 
> 
> This should be the same as
> 
> 	.yes_ranges = kx132_volatile_ranges,
> 

The driver uses &kx132_volatile_ranges[0] in a few places (for kx022a) 
so I believe this is okay. Well, I know I am biased as I do personally 
find &kx132_volatile_ranges[0] clearer. Here we point to the first 
element in an array - and yes, it may be I am minority here - but at 
least I wouldn't ask for changing this.

Yours,
	-- Matti

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~