linux-kernel - RE: [EXT] Re: [PATCH v2 net] octeontx2-pf: fix page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MWHPR1801MB19187F77B1DC0B22E85D8E4DD31DA@MWHPR1801MB1918.namprd18.prod.outlook.com>
Date:   Thu, 24 Aug 2023 02:40:26 +0000
From:   Ratheesh Kannoth <rkannoth@...vell.com>
To:     Alexander Lobakin <aleksander.lobakin@...el.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "hawk@...nel.org" <hawk@...nel.org>,
        "alexander.duyck@...il.com" <alexander.duyck@...il.com>,
        "ilias.apalodimas@...aro.org" <ilias.apalodimas@...aro.org>,
        "linyunsheng@...wei.com" <linyunsheng@...wei.com>
Subject: RE: [EXT] Re: [PATCH v2 net] octeontx2-pf: fix page_pool creation
 fail for rings > 32k

> From: Alexander Lobakin <aleksander.lobakin@...el.com>
> Sent: Wednesday, August 23, 2023 3:43 PM
> Subject: [EXT] Re: [PATCH v2 net] octeontx2-pf: fix page_pool creation fail
> for rings > 32k
> See now? I told ya you don't need that many to provide good recycling :> But
> nice to see it was confirmed 2k is enough.
Thanks !
 
> Isn't otx2_txrx.h a better place for this definition? For example, I'd place it
> somewhere between CGX_CHAN_BASE and OTX2_DATA_ALIGN. Or after
> MAX_XDP_MTU, doesn't matter much.
ACK.

> Don't forget about alignment. Otx2 code has very inconsistent alignment of
> definitions -- just one space in some places and proper tab alignment in
> others. I still believe we prefer the second for netdev code.
ACK.  Is it documented somewhere. I mean the coding std for netdev ?