linux-kernel - Re: [PATCH] kallsyms: Change func signature for cleanup_symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOd=QsgEBFs1ie0bhMMJaUk_pYZ9tQcPud9aRStaG-1uOEg@mail.gmail.com>
Date:   Fri, 25 Aug 2023 13:30:16 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Yonghong Song <yonghong.song@...ux.dev>
Cc:     Kees Cook <keescook@...omium.org>, Petr Mladek <pmladek@...e.com>,
        Song Liu <song@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Fangrui Song <maskray@...gle.com>, kernel-team@...com,
        Leizhen <thunder.leizhen@...wei.com>,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] kallsyms: Change func signature for cleanup_symbol_name()

On Fri, Aug 25, 2023 at 1:20 PM Yonghong Song <yonghong.song@...ux.dev> wrote:
>
> All users of cleanup_symbol_name() do not use the return value.
> So let us change the return value of cleanup_symbol_name() to
> 'void' to reflect its usage pattern.
>
> Suggested-by: Nick Desaulniers <ndesaulniers@...gle.com>
> Signed-off-by: Yonghong Song <yonghong.song@...ux.dev>

LGTM; thanks!
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

> ---
>  kernel/kallsyms.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>
> NOTE:
> This patch needs to be applied after the following patch:
> https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/commit/?id=33f0467fe069
>
> diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c
> index e12d26c10dba..18edd57b5fe8 100644
> --- a/kernel/kallsyms.c
> +++ b/kernel/kallsyms.c
> @@ -163,12 +163,12 @@ unsigned long kallsyms_sym_address(int idx)
>         return kallsyms_relative_base - 1 - kallsyms_offsets[idx];
>  }
>
> -static bool cleanup_symbol_name(char *s)
> +static void cleanup_symbol_name(char *s)
>  {
>         char *res;
>
>         if (!IS_ENABLED(CONFIG_LTO_CLANG))
> -               return false;
> +               return;
>
>         /*
>          * LLVM appends various suffixes for local functions and variables that
> @@ -178,12 +178,10 @@ static bool cleanup_symbol_name(char *s)
>          * - foo.llvm.[0-9a-f]+
>          */
>         res = strstr(s, ".llvm.");
> -       if (res) {
> +       if (res)
>                 *res = '\0';
> -               return true;
> -       }
>
> -       return false;
> +       return;
>  }
>
>  static int compare_symbol_name(const char *name, char *namebuf)
> --
> 2.34.1
>


-- 
Thanks,
~Nick Desaulniers