linux-kernel - Re: [PATCH v3 2/4] firmware: qcom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Aug 2023 14:42:49 -0700
From:   Brian Norris <computersforpeace@...il.com>
To:     Robert Marko <robimarko@...il.com>
Cc:     Mukesh Ojha <quic_mojha@...cinc.com>, agross@...nel.org,
        andersson@...nel.org, konrad.dybcio@...aro.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        quic_gurus@...cinc.com, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/4] firmware: qcom_scm: disable SDI if required

On Fri, Aug 25, 2023 at 2:41 AM Robert Marko <robimarko@...il.com> wrote:
> On Tue, 22 Aug 2023 at 17:38, Mukesh Ojha <quic_mojha@...cinc.com> wrote:
> > On 8/16/2023 10:15 PM, Robert Marko wrote:
> > > +     ret = qcom_scm_call(__scm->dev, &desc, &res);
> >
> > Would you not be wanting this call to be atomic ?
>
> This is implemented based off the downstream 5.4 kernel as I dont have
> the SCM docs
> so I dont know if its even supported in the atomic version.

More than that, it's known *not* to be properly supported on one such
applicable device:

Subject: [RFC] qcom_scm: IPQ4019 firmware does not support atomic API?
https://lore.kernel.org/linux-arm-kernel/20200913201608.GA3162100@bDebian/

I still haven't gotten a solution to *that* problem upstream, but it'd
be nice not to make it worse.

Brian