linux-kernel - Re: [PATCH -next] scsi: snic: fix double free in snic_tgt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169300023878.1212091.11390138946813564658.b4-ty@oracle.com>
Date:   Fri, 25 Aug 2023 17:50:59 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     kartilak@...co.com, sebaddel@...co.com, jejb@...ux.ibm.com,
        nmusini@...co.com, bvanassche@....org, dan.carpenter@...aro.org,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Zhu Wang <wangzhu9@...wei.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH -next] scsi: snic: fix double free in snic_tgt_create()

On Sat, 19 Aug 2023 08:39:41 +0000, Zhu Wang wrote:

> The commit 41320b18a0e0 ("scsi: snic: Fix possible memory leak if
> device_add() fails") fix the memory leak caused by dev_set_name() when
> device_add() failed. While it did not consider that 'tgt' has already been
> released when put_device(&tgt->dev) is called. We removed kfree(tgt) in
> the error path to avoid double free 'tgt'. And we moved
> put_device(&tgt->dev) after the removed kfree(tgt) to avoid UAF
> (Use-After-Free).
> 
> [...]

Applied to 6.5/scsi-fixes, thanks!

[1/1] scsi: snic: fix double free in snic_tgt_create()
      https://git.kernel.org/mkp/scsi/c/1bd3a76880b2

-- 
Martin K. Petersen	Oracle Linux Engineering