linux-kernel - Re: [PATCH] drm/msm/dp: Add newlines to debug printks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c229f00b-5e8b-b010-70bd-3478216c65a3@quicinc.com>
Date:   Fri, 25 Aug 2023 16:57:51 -0700
From:   Abhinav Kumar <quic_abhinavk@...cinc.com>
To:     Stephen Boyd <swboyd@...omium.org>,
        Rob Clark <robdclark@...il.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC:     <linux-kernel@...r.kernel.org>, <patches@...ts.linux.dev>,
        <linux-arm-msm@...r.kernel.org>, <freedreno@...ts.freedesktop.org>,
        <dri-devel@...ts.freedesktop.org>,
        Kuogee Hsieh <quic_khsieh@...cinc.com>,
        Vinod Polimera <quic_vpolimer@...cinc.com>
Subject: Re: [PATCH] drm/msm/dp: Add newlines to debug printks



On 8/25/2023 4:01 PM, Stephen Boyd wrote:
> These debug printks are missing newlines, causing drm debug logs to be
> hard to read. Add newlines so that the messages are on their own line.
> 
> Cc: Kuogee Hsieh <quic_khsieh@...cinc.com>
> Cc: Vinod Polimera <quic_vpolimer@...cinc.com>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
>   drivers/gpu/drm/msm/dp/dp_link.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/dp/dp_link.c b/drivers/gpu/drm/msm/dp/dp_link.c
> index 42427129acea..6375daaeb98e 100644
> --- a/drivers/gpu/drm/msm/dp/dp_link.c
> +++ b/drivers/gpu/drm/msm/dp/dp_link.c
> @@ -1090,7 +1090,7 @@ int dp_link_process_request(struct dp_link *dp_link)
>   	} else if (dp_link_read_psr_error_status(link)) {
>   		DRM_ERROR("PSR IRQ_HPD received\n");
>   	} else if (dp_link_psr_capability_changed(link)) {
> -		drm_dbg_dp(link->drm_dev, "PSR Capability changed");
> +		drm_dbg_dp(link->drm_dev, "PSR Capability changed\n");
>   	} else {
>   		ret = dp_link_process_link_status_update(link);
>   		if (!ret) {
> @@ -1107,7 +1107,7 @@ int dp_link_process_request(struct dp_link *dp_link)
>   		}
>   	}
>   
> -	drm_dbg_dp(link->drm_dev, "sink request=%#x",
> +	drm_dbg_dp(link->drm_dev, "sink request=%#x\n",
>   				dp_link->sink_request);

perhaps we can move sink_request to the previous line itself with this 
patch and we can avoid the line break.

But thats a very minor comment, otherwise LGTM

Reviewed-by: Abhinav Kumar <quic_abhinavk@...cinc.com>

>   	return ret;
>   }
> 
> base-commit: 706a741595047797872e669b3101429ab8d378ef