linux-kernel - Re: [PATCH v6 5/7] perf test: Update base-record & system-wide-dummy attr expected values for test-record-C0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0dbca9a3-f377-cd46-b1c4-e0742a94fbb5@huawei.com>
Date:   Fri, 25 Aug 2023 14:09:14 +0800
From:   Yang Jihong <yangjihong1@...wei.com>
To:     Ian Rogers <irogers@...gle.com>
CC:     <peterz@...radead.org>, <mingo@...hat.com>, <acme@...nel.org>,
        <mark.rutland@....com>, <alexander.shishkin@...ux.intel.com>,
        <jolsa@...nel.org>, <namhyung@...nel.org>,
        <adrian.hunter@...el.com>, <kan.liang@...ux.intel.com>,
        <james.clark@....com>, <tmricht@...ux.ibm.com>,
        <ak@...ux.intel.com>, <anshuman.khandual@....com>,
        <linux-kernel@...r.kernel.org>, <linux-perf-users@...r.kernel.org>
Subject: Re: [PATCH v6 5/7] perf test: Update base-record & system-wide-dummy
 attr expected values for test-record-C0

Hello,

On 2023/8/25 13:22, Ian Rogers wrote:
> On Sun, Aug 20, 2023 at 6:30 PM Yang Jihong <yangjihong1@...wei.com> wrote:
>>
>> 1. Because a dummy sideband event is added to the sampling of specified
>>     CPUs. When evlist contains evsel of different sample_type,
>>     evlist__config() will change the default PERF_SAMPLE_ID bit to
>>     PERF_SAMPLE_IDENTIFICATION bit.
>>     The attr sample_type expected value of base-record and system-wide-dummy
>>     in test-record-C0 needs to be updated.
>>
>> 2. The perf record uses evlist__add_aux_dummy() instead of
>>     evlist__add_dummy() to add a dummy event.
>>     The expected value of system-wide-dummy attr needs to be updated.
>>
>> The perf test result is as follows:
>>
>>    # ./perf test list  2>&1 | grep 'Setup struct perf_event_attr'
>>     17: Setup struct perf_event_attr
>>    # ./perf test 17
>>     17: Setup struct perf_event_attr                                    : Ok
> 
> Will the kernel test robot complain about the previous patches
> breaking this test? It may be best to update the test while changing
> the behavior in those patches.
> 
Okay, it'll be modified in the next version.

Thanks,
Yang