linux-kernel - Re: [PATCH 2/3] selftests/resctrl: Move run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jaqand55qwxm3euuqfu5wldkpvjtan4mbve3jsyixa6kstjtwp@rbj5stuvduj4>
Date:   Fri, 25 Aug 2023 08:26:35 +0200
From:   Maciej Wieczór-Retman 
        <maciej.wieczor-retman@...el.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
CC:     LKML <linux-kernel@...r.kernel.org>,
        Reinette Chatre <reinette.chatre@...el.com>,
        <fenghua.yu@...el.com>
Subject: Re: [PATCH 2/3] selftests/resctrl: Move run_benchmark() to a more
 fitting file

Hello,

On 2023-08-24 at 15:56:25 +0300, Ilpo Järvinen wrote:
>On Thu, 24 Aug 2023, Wieczor-Retman, Maciej wrote:
>
>Thanks for this patch, the new location is much more appropriate and 
>logical (more than once I've tried to look for this from the wrong file).
>
>> Resctrlfs.c file contains mostly functions that interact in some way
>> with resctrl FS entries while functions inside resctrl_val.c deal with
>> measurements and benchmarking
>> 
>> Run_benchmark() function is located in resctrlfs.c file even though it's
>> purpose is not interacting with the resctrl FS but to execute cache
>> checking logic
>> 
>> Move run_benchmark() to resctrl_val.c just before resctrl_val() function
>> that makes use of run_benchmark()
>
>Please terminate your sentences in changelog with . like in normal 
>writing.

Sure, I'll change it for the next version

>> Signed-off-by: Wieczor-Retman, Maciej <maciej.wieczor-retman@...el.com>
>> ---
>>  tools/testing/selftests/resctrl/resctrl_val.c | 52 +++++++++++++++++++
>>  tools/testing/selftests/resctrl/resctrlfs.c   | 52 -------------------
>>  2 files changed, 52 insertions(+), 52 deletions(-)
>> 
>> diff --git a/tools/testing/selftests/resctrl/resctrl_val.c b/tools/testing/selftests/resctrl/resctrl_val.c
>> index f0f6c5f6e98b..667542c084eb 100644
>> --- a/tools/testing/selftests/resctrl/resctrl_val.c
>> +++ b/tools/testing/selftests/resctrl/resctrl_val.c
>> @@ -621,6 +621,58 @@ measure_vals(struct resctrl_val_param *param, unsigned long *bw_resc_start)
>>  	return 0;
>>  }
>>  
>> +/*
>> + * run_benchmark - Run a specified benchmark or fill_buf (default benchmark)
>> + *		   in specified signal. Direct benchmark stdio to /dev/null.
>> + * @signum:	signal number
>> + * @info:	signal info
>> + * @ucontext:	user context in signal handling
>> + *
>> + * Return: void
>
>This Return: void feels waste of screen space as if it wouldn't be 
>obvious from the function signature.

I'll remove it

-- 
Kind regards
Maciej Wieczór-Retman