linux-kernel - Re: [PATCH v1] drivers: edac: Drop unnecessary error check for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <723e803b-6f8b-ceb3-e987-4a6f83d89222@amd.com>
Date:   Fri, 25 Aug 2023 09:31:54 +0200
From:   Michal Simek <michal.simek@....com>
To:     Atul Kumar Pant <atulpant.linux@...il.com>,
        <shubhrajyoti.datta@....com>, <sai.krishna.potthuri@....com>,
        <bp@...en8.de>, <tony.luck@...el.com>, <james.morse@....com>,
        <mchehab@...nel.org>, <rric@...nel.org>
CC:     <linux-edac@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <shuah@...nel.org>
Subject: Re: [PATCH v1] drivers: edac: Drop unnecessary error check for
 debugfs_create_dir

On 8/15/23 22:38, Atul Kumar Pant wrote:
> This patch removes the error checking for debugfs_create_dir.

Avoid using "This patch".

> Even if we get an error from this function, other debugfs APIs will
> handle the error value and doesn't crash in that case. Hence caller can
> safely ignore the errors that occur during the creation of debugfs nodes.

First of all which issue do you have? Did you see that folder is not created?

I am not quite sure if this is the right behavior.
In the code there is
135         if (!parent)
136                 parent = edac_debugfs;

It means you are right that if creating ocm folder can fail and properties will 
be still created under edac_debugfs but is this the right behavior?

altera_edac/armada_xp_edac/i10nm/i5100/igen6/others are checking return value 
that's why I can't see any reason to remove this checking from one driver.

If you want to fix all please send patch for all but I don't think it will 
improve situation and it will just hide different issue if creating folder fails.
And debugfs will be disabled in production system anyway.

Thanks,
Michal