linux-kernel - Re: [PATCH] mm/vmscan: Use folio_migratetype() instead of get_pageblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Aug 2023 09:34:52 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Vern Hao <haoxing990@...il.com>, akpm@...ux-foundation.org
Cc:     zhaoyang.huang@...soc.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Vern Hao <vernhao@...cent.com>
Subject: Re: [PATCH] mm/vmscan: Use folio_migratetype() instead of
 get_pageblock_migratetype()

On 25.08.23 09:31, Vern Hao wrote:
> 
> 在 2023/8/25 15:12, David Hildenbrand 写道:
>> On 25.08.23 06:08, Vern Hao wrote:
>>> From: Vern Hao <vernhao@...cent.com>
>>>
>>> In skip_cma(), we can use folio_migratetype() to replace
>>> get_pageblock_migratetype().
>>>
>>> Fixes: 5da226dbfce3 ("mm: skip CMA pages when they are not available")
>>
>> Why did you think "Fixes" was a good idea?
>>
> The skip_cma() contains the folio argument, and the folio_migratetype()
> is already implemented in the kernel, so I think it's fine to keep it
> consistent.

If this doesn't actually *fix a bug*, then please don't add fixes and 
confuse people looking for actual bugfixes.

See Documentation/process/submitting-patches.rst

-- 
Cheers,

David / dhildenb