linux-kernel - Re: [PATCH v2] mm/vmscan: Use folio_migratetype() instead of get_pageblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56300927-4b81-8acc-58d3-4cbe0f1d60f1@redhat.com>
Date:   Fri, 25 Aug 2023 10:03:44 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Vern Hao <haoxing990@...il.com>, akpm@...ux-foundation.org
Cc:     zhaoyang.huang@...soc.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Vern Hao <vernhao@...cent.com>
Subject: Re: [PATCH v2] mm/vmscan: Use folio_migratetype() instead of
 get_pageblock_migratetype()

On 25.08.23 09:57, Vern Hao wrote:
> From: Vern Hao <vernhao@...cent.com>
> 
> In skip_cma(), we can use folio_migratetype() to replace get_pageblock_migratetype().
> 
> Signed-off-by: Vern Hao <vernhao@...cent.com>
> ---
> v1 -> v2
> 	- remove "Fixs:xxx" as David Hildenbrand suggestion.
> 
>   mm/vmscan.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 2b5d61eeb039..850811bb5699 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2271,7 +2271,7 @@ static bool skip_cma(struct folio *folio, struct scan_control *sc)
>   {
>   	return !current_is_kswapd() &&
>   			gfp_migratetype(sc->gfp_mask) != MIGRATE_MOVABLE &&
> -			get_pageblock_migratetype(&folio->page) == MIGRATE_CMA;
> +			folio_migratetype(folio) == MIGRATE_CMA;

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb