linux-kernel - Re: [PATCH v2] brcm80211: brcmsmac: phy: Remove unreachable code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOiHx=nU7POAE8SFD833inLm59CMiNmQpE28XWLjVcHS5a5zHA@mail.gmail.com>
Date:   Fri, 25 Aug 2023 10:34:07 +0200
From:   Jonas Gorski <jonas.gorski@...il.com>
To:     Artem Chernyshev <artem.chernyshev@...-soft.ru>
Cc:     Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Arend van Spriel <aspriel@...il.com>,
        Kalle Valo <kvalo@...nel.org>, linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        SHA-cyfmac-dev-list@...ineon.com, linux-kernel@...r.kernel.org,
        lvc-project@...uxtesting.org
Subject: Re: [PATCH v2] brcm80211: brcmsmac: phy: Remove unreachable code

Hi,

On Mon, 14 Aug 2023 at 11:36, Artem Chernyshev
<artem.chernyshev@...-soft.ru> wrote:
>
> wlc_phy_txpwr_srom_read_nphy() in wlc_phy_attach_nphy() can not
> return false, so it's impossible to get true value in this
> if-statement. Also change those functions return types to void
> since no one using it.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Artem Chernyshev <artem.chernyshev@...-soft.ru>

Since Broadcom seems to be on vacation or so, have a

Reviewed-by: Jonas Gorski <jonas.gorski@...il.com>

to have at least some feedback.

Regards,
Jonas