[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <60fcef0b71c3b6a5a35bd2bf706af7545acc3e6a.camel@gmail.com>
Date: Fri, 25 Aug 2023 11:28:48 +0200
From: Angel Iglesias <ang.iglesiasg@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
Jonathan Cameron <jic23@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v2 1/3] iio: pressure: bmp280: Use uint8 to store chip
ids
On Wed, 2023-08-23 at 19:17 +0300, Andy Shevchenko wrote:
> On Wed, Aug 23, 2023 at 07:10:33PM +0300, Andy Shevchenko wrote:
> > On Wed, Aug 23, 2023 at 05:58:05PM +0200, Angel Iglesias wrote:
> > > Represent the device id reg values using uint8 to optimize memory use.
> >
> > This doesn't correspond to the code, in the code you used uint8_t.
>
> ...
>
> > > struct bmp280_chip_info {
> > > unsigned int id_reg;
> > > - const unsigned int chip_id;
> > > + uint8_t chip_id;
> >
> > While this will compile and even work properly in kernel we use uXX types,
> > here u8.
>
> Actually this patch doesn't optimize memory use. The alignment will create
> a gap anyway.
>
> That said, this patch is simply redundant.
>
OK, I'll drop it on v3 then
Powered by blists - more mailing lists