linux-kernel - Re: [PATCH v2 2/2] crypto: qat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZOig0RNTKs+P91V0@smile.fi.intel.com>
Date:   Fri, 25 Aug 2023 15:38:41 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Lucas Segarra Fernandez <lucas.segarra.fernandez@...el.com>,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        qat-linux@...el.com, alx@...nel.org,
        Giovanni Cabiddu <giovanni.cabiddu@...el.com>
Subject: Re: [PATCH v2 2/2] crypto: qat - add pm_status debugfs file

On Fri, Aug 25, 2023 at 06:39:36PM +0800, Herbert Xu wrote:
> On Fri, Aug 18, 2023 at 12:23:09PM +0200, Lucas Segarra Fernandez wrote:

> >  #include <linux/bitfield.h>
> > +#include <linux/bits.h>
> 
> This is redundant if you include linux/kernel.

Why?!
Can we avoid using kernel.h, please?

> > +#include <linux/dma-mapping.h>
> > +#include <linux/fs.h>
> >  #include <linux/iopoll.h>
> >  #include <linux/kstrtox.h>
> > +#include <linux/slab.h>
> > +#include <linux/stddef.h>
> 
> So is this.

Ditto.

-- 
With Best Regards,
Andy Shevchenko