linux-kernel - [PATCH v2 0/6] Fix missing caps, fix unnecessary casting/checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230825024002.801955-1-irogers@google.com>
Date:   Thu, 24 Aug 2023 19:39:56 -0700
From:   Ian Rogers <irogers@...gle.com>
To:     John Garry <john.g.garry@...cle.com>,
        Will Deacon <will@...nel.org>,
        James Clark <james.clark@....com>,
        Mike Leach <mike.leach@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Ravi Bangoria <ravi.bangoria@....com>,
        Suzuki Poulouse <suzuki.poulose@....com>,
        Kajol Jain <kjain@...ux.ibm.com>,
        Athira Rajeev <atrajeev@...ux.vnet.ibm.com>,
        Ming Wang <wangming01@...ngson.cn>,
        Huacai Chen <chenhuacai@...nel.org>,
        Sean Christopherson <seanjc@...gle.com>,
        K Prateek Nayak <kprateek.nayak@....com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        Wei Li <liwei391@...wei.com>
Subject: [PATCH v2 0/6] Fix missing caps, fix unnecessary casting/checking

Wei Li <liwei391@...wei.com> reported an issue where writing PMU caps
for ARM was broken. Patch 1 addresses this issue.

Patch 2 removes unnecessary checks on a PMU's name by ensuring the
fake PMU has a name. Types are updated to have a const as a
consequence and a cleanup of the use of types is done for struct pmu's
variable name. This was motivated by the discussion:
https://lore.kernel.org/lkml/20230818171952.3719251-1-irogers@google.com/

Patches 3-5 repeat the const cleanup on struct pmu's name with the
variables id and config in struct pmu and struct parse_events_term
respectively. This is done for consistency with patch 2.

Patch 6 tidies casts around libslang and removes workarounds for
libslang support needed for a libslang older than 15 years - let's say
nobody cares about a libslang that is this old.

Ian Rogers (6):
  perf header: Fix missing PMU caps
  perf pmu: Remove logic for PMU name being NULL
  perf parse-events: Make term's config const
  perf pmu: Make id const and add missing free
  perf build-id: Simplify build_id_cache__cachedir
  perf tui slang: Tidy casts

 tools/perf/arch/arm64/util/mem-events.c   |  2 +-
 tools/perf/arch/powerpc/util/mem-events.c |  6 ++--
 tools/perf/arch/x86/util/mem-events.c     |  8 ++---
 tools/perf/arch/x86/util/pmu.c            | 10 +++---
 tools/perf/builtin-list.c                 |  2 +-
 tools/perf/tests/pmu-events.c             | 20 ++++++------
 tools/perf/tests/pmu.c                    | 18 +++++------
 tools/perf/ui/Build                       |  2 --
 tools/perf/ui/browser.c                   |  6 ++--
 tools/perf/ui/browsers/Build              |  5 ---
 tools/perf/ui/libslang.h                  | 20 +++---------
 tools/perf/ui/tui/helpline.c              |  2 +-
 tools/perf/ui/tui/setup.c                 |  2 +-
 tools/perf/ui/tui/util.c                  | 12 +++----
 tools/perf/util/build-id.c                |  6 ++--
 tools/perf/util/env.c                     |  8 ++---
 tools/perf/util/header.c                  | 39 ++++++++++-------------
 tools/perf/util/mem-events.c              | 16 +++++-----
 tools/perf/util/mem-events.h              |  2 +-
 tools/perf/util/parse-events.c            | 17 ++++------
 tools/perf/util/parse-events.h            |  6 ++--
 tools/perf/util/parse-events.y            |  2 +-
 tools/perf/util/pmu.c                     | 19 ++++++-----
 tools/perf/util/pmu.h                     | 10 +++---
 24 files changed, 105 insertions(+), 135 deletions(-)

-- 
2.42.0.rc2.253.gd59a3bf2b4-goog