linux-kernel - Re: [PATCH v2 06/18] perf s390 s390_cpumcfdg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f2438fc-2360-8833-3751-fe3bc8b11afb@linux.ibm.com>
Date:   Fri, 25 Aug 2023 16:39:22 +0200
From:   Thomas Richter <tmricht@...ux.ibm.com>
To:     Ian Rogers <irogers@...gle.com>,
        Sumanth Korikkar <sumanthk@...ux.ibm.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Jiri Olsa <jolsa@...nel.org>,
        James Clark <james.clark@....com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 06/18] perf s390 s390_cpumcfdg_dump: Don't scan all
 PMUs

On 8/25/23 15:14, Ian Rogers wrote:
> On Fri, Aug 25, 2023 at 1:20 AM Thomas Richter <tmricht@...ux.ibm.com> wrote:
>>
>> On 8/24/23 15:59, Arnaldo Carvalho de Melo wrote:
>>> Em Wed, Aug 23, 2023 at 09:13:18PM -0700, Ian Rogers escreveu:
>>>> Rather than scanning all PMUs for a counter name, scan the PMU
>>>> associated with the evsel of the sample. This is done to remove a
>>>> dependence on pmu-events.h.
>>>
>>> I'm applying this one, and CCing the S/390 developers so that they can
>>> try this and maybe provide an Acked-by/Tested-by,
>>>
>>> - Arnaldo
>>
>>
>> Arnaldo,
>>
>> I have downloaded this patch set of 18 patches (using b4), but they do not
>> apply on my git tree.
>>
>> Which git branch do I have to use to test this. Thanks a lot.
> 
> Hi Thomas,
> 
> the changes are in the perf-tools-next tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/
> 
> Thanks,
> Ian
> 

Hi Ian,

thanks for the pointer.

Unfurtunately this patch set fails again on s390.
Here is the test output from the current 6.5.0rc7 kernel:

# ./perf test 6 10 'perf all metricgroups test' 'perf all metrics test'
  6: Parse event definition strings                                  :
  6.1: Test event parsing                                            : Ok
  6.2: Parsing of all PMU events from sysfs                          : Ok
  6.3: Parsing of given PMU events from sysfs                        : Ok
  6.4: Parsing of aliased events from sysfs                          : Skip (no aliases in sysfs)
  6.5: Parsing of aliased events                                     : Ok
  6.6: Parsing of terms (event modifiers)                            : Ok
 10: PMU events                                                      :
 10.1: PMU event table sanity                                        : Ok
 10.2: PMU event map aliases                                         : Ok
 10.3: Parsing of PMU event table metrics                            : Ok
 10.4: Parsing of PMU event table metrics with fake PMUs             : Ok
 10.5: Parsing of metric thresholds with fake PMUs                   : Ok
 95: perf all metricgroups test                                      : Ok
 96: perf all metrics test                                           : Ok
# 

This looks good.

However when I use the check-out from perf-tools-next, I get this output:
# ./perf test 6 10 'perf all metricgroups test' 'perf all metrics test'
  6: Parse event definition strings                                  :
  6.1: Test event parsing                                            : Ok
  6.2: Parsing of all PMU events from sysfs                          : FAILED!
  6.3: Parsing of given PMU events from sysfs                        : Ok
  6.4: Parsing of aliased events from sysfs                          : Skip (no aliases in sysfs)
  6.5: Parsing of aliased events                                     : FAILED!
  6.6: Parsing of terms (event modifiers)                            : Ok
 10: PMU events                                                      :
 10.1: PMU event table sanity                                        : Ok
 10.2: PMU event map aliases                                         : FAILED!
 10.3: Parsing of PMU event table metrics                            : Ok
 10.4: Parsing of PMU event table metrics with fake PMUs             : FAILED!
 10.5: Parsing of metric thresholds with fake PMUs                   : Ok
 93: perf all metricgroups test                                      : FAILED!
 94: perf all metrics test                                           : FAILED!
# 

So some tests are failing again.

I am out for the next two weeks, Sumanth Korikkar (on to list) might be able to help.
Thanks a lot.

-- 
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294