linux-kernel - Re: [PATCH v5 02/10] kunit: string-stream: Improve testing of string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b0c2e85f-fcc1-55fb-cef2-2e2d0fe56747@opensource.cirrus.com>
Date:   Fri, 25 Aug 2023 15:58:53 +0100
From:   Richard Fitzgerald <rf@...nsource.cirrus.com>
To:     Rae Moar <rmoar@...gle.com>
CC:     <brendan.higgins@...ux.dev>, <davidgow@...gle.com>,
        <linux-kselftest@...r.kernel.org>, <kunit-dev@...glegroups.com>,
        <linux-kernel@...r.kernel.org>, <patches@...nsource.cirrus.com>
Subject: Re: [PATCH v5 02/10] kunit: string-stream: Improve testing of
 string_stream

On 24/08/2023 23:42, Rae Moar wrote:
> On Thu, Aug 24, 2023 at 10:31 AM Richard Fitzgerald
> <rf@...nsource.cirrus.com> wrote:
>>
>> Replace the minimal tests with more-thorough testing.
>>

<SNIP>

>> +       KUNIT_EXPECT_EQ(test, stream->gfp, GFP_KERNEL);
> 
> As mentioned in the last version, if this causes a warning we will
> look into it on the KUnit side.
>

It does. I left it because you said you'd do a fix.
But maybe it's better to change it to

KUNIT_EXPECT_TRUE(test, stream_gfp == GFP_KERNEL);

to avoid the warning for now.