linux-kernel - Re: [PATCH v2] xfs: fix select in config XFS_ONLINE_SCRUB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Aug 2023 08:15:01 -0700
From:   "Darrick J. Wong" <djwong@...nel.org>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Chandan Babu R <chandan.babu@...cle.com>,
        Dave Chinner <dchinner@...hat.com>, linux-xfs@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] xfs: fix select in config XFS_ONLINE_SCRUB_STATS

On Fri, Aug 25, 2023 at 02:05:13PM +0200, Lukas Bulwahn wrote:
> Commit d7a74cad8f45 ("xfs: track usage statistics of online fsck")
> introduces config XFS_ONLINE_SCRUB_STATS, which selects the non-existing
> config FS_DEBUG. It is probably intended to select the existing config
> XFS_DEBUG.
> 
> Fix the select in config XFS_ONLINE_SCRUB_STATS.
> 
> Fixes: d7a74cad8f45 ("xfs: track usage statistics of online fsck")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>

Oops.
Reviewed-by: Darrick J. Wong <djwong@...nel.org>

> ---
> Darrick, please pick this quick 'typo' fix.

  ^^^^ isn't the maintainer anymore. ;)

--D

> v2: removed a stupid last-minute insert on my Signed-off-by line.
> 
>  fs/xfs/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> index c9d653168ad0..ed0bc8cbc703 100644
> --- a/fs/xfs/Kconfig
> +++ b/fs/xfs/Kconfig
> @@ -147,7 +147,7 @@ config XFS_ONLINE_SCRUB_STATS
>  	bool "XFS online metadata check usage data collection"
>  	default y
>  	depends on XFS_ONLINE_SCRUB
> -	select FS_DEBUG
> +	select XFS_DEBUG
>  	help
>  	  If you say Y here, the kernel will gather usage data about
>  	  the online metadata check subsystem.  This includes the number
> -- 
> 2.17.1
>