linux-kernel - Re: [PATCH] x86/sgx: Describe the parameters of sgx_calc_section

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba319881-b4e9-7129-123f-1884bfeb50ec@intel.com>
Date:   Fri, 25 Aug 2023 08:18:32 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Jarkko Sakkinen <jarkko@...nel.org>, linux-sgx@...r.kernel.org
Cc:     stable@...r.kernel.org, kernel test robot <lkp@...el.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
        Jethro Beekman <jethro@...tanix.com>,
        Serge Ayoun <serge.ayoun@...el.com>,
        Sean Christopherson <seanjc@...gle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/sgx: Describe the parameters of
 sgx_calc_section_metric()

On 8/22/23 03:28, Jarkko Sakkinen wrote:
> Cc: stable@...r.kernel.org # v5.11+
> Fixes: e7e0545299d8 ("x86/sgx: Initialize metadata for Enclave Page Cache (EPC) sections")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308221542.11UpkVfp-lkp@intel.com/
> Signed-off-by: Jarkko Sakkinen <jarkko@...nel.org>

-ENOCHANGELOG

>  /**
> + * sgx_calc_section_metric() - Calculate an EPC section metric
> + * @low:	low 32-bit word from CPUID:0x12:{2, ...}
> + * @high:	high 32-bit word from CPUID:0x12:{2, ...}
> + *
>   * A section metric is concatenated in a way that @low bits 12-31 define the
>   * bits 12-31 of the metric and @high bits 0-19 define the bits 32-51 of the
>   * metric.

Shouldn't we just do:

-  /**
+  /*

?  This doesn't need kerneldoc comments.