linux-kernel - Re: [PATCH v2 1/2] selftests: Provide local define of min() and max()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZOjIHo2A6HZ8K4Qp@google.com>
Date:   Fri, 25 Aug 2023 08:26:22 -0700
From:   Sean Christopherson <seanjc@...gle.com>
To:     Mahmoud Maatuq <mahmoudmatook.mm@...il.com>
Cc:     keescook@...omium.org, edumazet@...gle.com,
        willemdebruijn.kernel@...il.com, wad@...omium.org,
        luto@...capital.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kuba@...nel.org, shuah@...nel.org,
        pabeni@...hat.com, linux-kselftest@...r.kernel.org,
        davem@...emloft.net,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        David Laight <David.Laight@...lab.com>
Subject: Re: [PATCH v2 1/2] selftests: Provide local define of min() and max()

On Fri, Aug 25, 2023, Mahmoud Maatuq wrote:
> to avoid manual calculation of min and max values
> and fix coccinelle warnings such WARNING opportunity for min()/max()
> adding one common definition that could be used in multiple files
> under selftests.
> there are also some defines for min/max scattered locally inside sources
> under selftests.
> this also prepares for cleaning up those redundant defines and include
> kselftest.h instead.
> 
> Signed-off-by: Mahmoud Maatuq <mahmoudmatook.mm@...il.com>
> Suggested-by: David Laight <David.Laight@...lab.com>
> ---
> changes in v2:
> redefine min/max in a more strict way to avoid 
> signedness mismatch and multiple evaluation.
> is_signed_type() moved from selftests/kselftest_harness.h 
> to selftests/kselftest.h.
> ---
>  tools/testing/selftests/kselftest.h         | 24 +++++++++++++++++++++

Heh, reminds me of https://xkcd.com/927.

All of these #defines are available in tools/include/linux/kernel.h, and it's
trivially easy for selftests to add all of tools/include to their include path.
I don't see any reason for the selftests framework to define yet another version,
just fix the individual tests.