[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20230826065055.4691-1-vbrahmajosyula@vmware.com>
Date: Sat, 26 Aug 2023 06:50:56 +0000
From: Vamsi Krishna Brahmajosyula <vbrahmajosyula@...are.com>
To: stable@...r.kernel.org
Cc: gregkh@...uxfoundation.org, patches@...ts.linux.dev,
pablo@...filter.org, kadlec@...ckhole.kfki.hu, fw@...len.de,
davem@...emloft.net, netfilter-devel@...r.kernel.org,
coreteam@...filter.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, amakhalov@...are.com,
srinidhir@...are.com, vsirnapalli@...are.com, akaher@...are.com,
tkundu@...are.com, keerthanak@...are.com, psinghchauha@...are.com,
Vimal Agrawal <vimal.agrawal@...hos.com>
Subject: [PATCH v4.19.y] netfilter: nf_queue: fix socket leak
Removal of the sock_hold got lost when backporting commit c3873070247d
("netfilter: nf_queue: fix possible use-after-free") to 4.19
Fixes: 34dc4a6a7f26 ("netfilter: nf_queue: fix possible use-after-free") in 4.19
Fixed in 4.14 with
https://lore.kernel.org/all/20221024112958.115275475@linuxfoundation.org/
Signed-off-by: Vimal Agrawal <vimal.agrawal@...hos.com>
Reviewed-by: Florian Westphal <fw@...len.de>
[vbrahmajosyula: The fix to the backport was missed in 4.19]
Signed-off-by: Vamsi Krishna Brahmajosyula <vbrahmajosyula@...are.com>
---
net/netfilter/nf_queue.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/netfilter/nf_queue.c b/net/netfilter/nf_queue.c
index 84c59de27882..b3a0385290a1 100644
--- a/net/netfilter/nf_queue.c
+++ b/net/netfilter/nf_queue.c
@@ -93,8 +93,6 @@ bool nf_queue_entry_get_refs(struct nf_queue_entry *entry)
dev_hold(state->in);
if (state->out)
dev_hold(state->out);
- if (state->sk)
- sock_hold(state->sk);
#if IS_ENABLED(CONFIG_BRIDGE_NETFILTER)
if (entry->skb->nf_bridge) {
struct net_device *physdev;
--
2.39.2
Powered by blists - more mailing lists