linux-kernel - Re: [PATCH v4 09/10] iommu: Make iommu_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ace23a3-ecf9-551f-1c5e-be5b6502c563@linux.intel.com>
Date:   Sat, 26 Aug 2023 15:32:06 +0800
From:   Baolu Lu <baolu.lu@...ux.intel.com>
To:     "Tian, Kevin" <kevin.tian@...el.com>,
        Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Jean-Philippe Brucker <jean-philippe@...aro.org>,
        Nicolin Chen <nicolinc@...dia.com>
Cc:     baolu.lu@...ux.intel.com, "Liu, Yi L" <yi.l.liu@...el.com>,
        Jacob Pan <jacob.jun.pan@...ux.intel.com>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 09/10] iommu: Make iommu_queue_iopf() more generic

On 8/25/23 4:17 PM, Tian, Kevin wrote:
>> From: Lu Baolu <baolu.lu@...ux.intel.com>
>> Sent: Friday, August 25, 2023 10:30 AM
>>
>> +	if (fault->prm.flags & IOMMU_FAULT_PAGE_REQUEST_PASID_VALID)
>> +		domain = iommu_get_domain_for_dev_pasid(dev, fault-
>>> prm.pasid, 0);
>> +	else
>> +		domain = iommu_get_domain_for_dev(dev);
>> +
>> +	if (!domain || !domain->iopf_handler) {
>> +		dev_warn_ratelimited(dev,
>> +			"iopf from pasid %d received without handler
>> installed\n",
> 
> "without domain attached or handler installed"

Okay.

> 
>>
>> +int iommu_sva_handle_iopf(struct iopf_group *group)
>> +{
>> +	struct iommu_fault_param *fault_param = group->dev->iommu-
>>> fault_param;
>> +
>> +	INIT_WORK(&group->work, iopf_handler);
>> +	if (!queue_work(fault_param->queue->wq, &group->work))
>> +		return -EBUSY;
>> +
>> +	return 0;
>> +}
> 
> this function is generic so the name should not tie to 'sva'.

Currently only sva uses it. It's fine to make it generic later when any
new use comes. Does it work to you?

Best regards,
baolu