[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2023082600-moisture-corroding-c1e9@gregkh>
Date: Sat, 26 Aug 2023 09:40:20 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: "Patel, Utkarsh H" <utkarsh.h.patel@...el.com>
Cc: Prashant Malani <pmalani@...omium.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
"heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
"bleung@...omium.org" <bleung@...omium.org>
Subject: Re: [PATCH v4 1/2] platform/chrome: cros_ec_typec: Configure Retimer
cable type
On Fri, Aug 25, 2023 at 09:04:29PM +0000, Patel, Utkarsh H wrote:
> Hi Greg,
>
> > > > >
> > > > > We are only calling it once depending upon which mode we enter TBT
> > > > > Alt or
> > > > USB4.
> > > >
> > > > There should only be 1 "call site" and that should be sufficient to
> > > > grab the VDO from the framework for all circumstances. Whether the
> > > > other invocation doesn't get called under certain circumstances isn't as
> > relevant.
> > >
> > > Are you suggesting something like this?
> > >
> > > static int cros_typec_configure_mux(struct cros_typec_data *typec, int
> > port_num,)...
> > >
> > > if (port->mux_flags & USB_PD_MUX_USB4_ENABLED ||
> > > port->mux_flags & USB_PD_MUX_TBT_COMPAT_ENABLED)
> > > cable_tbt_vdo = cros_typec_get_cable_vdo(port,
> > USB_TYPEC_TBT_SID);
> >
> > My apologies, I misread the patch. I think this looks good.
> >
> > Acked-by: Prashant Malani <pmalani@...omium.org>
>
> Could you please add this patch to usb-next.
Ugh, it's late in the cycle, but this has been around for a while, let
me go see...
Powered by blists - more mailing lists