linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: sc7180: Reorganize trogdor rt5682 audio codec dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <610a1b08-ced2-4e07-8b69-b2dd2749293e@linaro.org>
Date:   Sat, 26 Aug 2023 11:36:17 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Douglas Anderson <dianders@...omium.org>,
        Bjorn Andersson <andersson@...nel.org>
Cc:     Sheng-Liang Pan <sheng-liang.pan@...nta.corp-partner.google.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        cros-qcom-dts-watchers@...omium.org, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc7180: Reorganize trogdor rt5682
 audio codec dts

On 16.08.2023 20:21, Douglas Anderson wrote:
> It was asserted that the "/delete-property/ VBAT-supply;" that we
> needed to do in the rt5682s dts fragment was ugly. Let's change up all
> the trogdor device trees to make it explicit which version of "rt5682"
> we have and avoid the need for the "delete-property".
> 
> As a side effect, this nicely gets rid of the need for a delete-node
> in coachz, which doesn't use "rt5682" at all.
> 
> A few notes:
> - This doesn't get rid of every "/delete-node/" in trogdor, just the
>   one that was used for rt5682s.
> - Though we no longer have any "/delete-node/", we do still override
>   the "model" in the "sound" node in one case (in pompom) since that
>   uses the "2mic" sound setup.
> 
> This is validated to produce the same result (other than a few
> properties being reordered) when taking the dtbs generated by the
> kernel build and then doing:
> 
>   for dtb in *trogdor*.dtb; do
>     dtc -I dtb -O dts $dtb -o out/$dtb.dts;
>   done
> 
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
[...]

> +&mdss_dsi0_phy {
> +	qcom,phy-rescode-offset-top = /bits/ 8 <31 31 31 31 (-32)>;
> +	qcom,phy-rescode-offset-bot = /bits/ 8 <31 31 31 31 (-32)>;
> +	qcom,phy-drive-ldo-level = <450>;
> +};
> +
> +&panel {
> +	compatible = "boe,tv110c9m-ll3";
> +};
This is odd

Konrad