linux-kernel - Re: linux-next: Tree for Aug 23 (drivers/platform/x86/amd/pmc.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <613570c6-7f5d-778c-183a-4aeb967c69d8@redhat.com>
Date:   Sat, 26 Aug 2023 12:09:17 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:X86 PLATFORM DRIVERS" 
        <platform-driver-x86@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Tree for Aug 23 (drivers/platform/x86/amd/pmc.c)

Hi All,

On 8/24/23 04:06, Randy Dunlap wrote:
> 
> 
> On 8/22/23 23:14, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20230822:
>>
>> New tree: drm-ci
>>
> 
> on x86_64:
> # CONFIG_SUSPEND is not set
> # CONFIG_PM is not set
> 
> 
> ../drivers/platform/x86/amd/pmc.c:878:15: error: variable ‘amd_pmc_s2idle_dev_ops’ has initializer but incomplete type
>   878 | static struct acpi_s2idle_dev_ops amd_pmc_s2idle_dev_ops = {
>       |               ^~~~~~~~~~~~~~~~~~~
> ../drivers/platform/x86/amd/pmc.c:879:10: error: ‘struct acpi_s2idle_dev_ops’ has no member named ‘prepare’
>   879 |         .prepare = amd_pmc_s2idle_prepare,
>       |          ^~~~~~~
> ../drivers/platform/x86/amd/pmc.c:879:20: warning: excess elements in struct initializer
>   879 |         .prepare = amd_pmc_s2idle_prepare,
>       |                    ^~~~~~~~~~~~~~~~~~~~~~
> ../drivers/platform/x86/amd/pmc.c:879:20: note: (near initialization for ‘amd_pmc_s2idle_dev_ops’)
> ../drivers/platform/x86/amd/pmc.c:880:10: error: ‘struct acpi_s2idle_dev_ops’ has no member named ‘check’
>   880 |         .check = amd_pmc_s2idle_check,
>       |          ^~~~~
> ../drivers/platform/x86/amd/pmc.c:880:18: warning: excess elements in struct initializer
>   880 |         .check = amd_pmc_s2idle_check,
>       |                  ^~~~~~~~~~~~~~~~~~~~
> ../drivers/platform/x86/amd/pmc.c:880:18: note: (near initialization for ‘amd_pmc_s2idle_dev_ops’)
> ../drivers/platform/x86/amd/pmc.c:881:10: error: ‘struct acpi_s2idle_dev_ops’ has no member named ‘restore’
>   881 |         .restore = amd_pmc_s2idle_restore,
>       |          ^~~~~~~
> ../drivers/platform/x86/amd/pmc.c:881:20: warning: excess elements in struct initializer
>   881 |         .restore = amd_pmc_s2idle_restore,
>       |                    ^~~~~~~~~~~~~~~~~~~~~~
> ../drivers/platform/x86/amd/pmc.c:881:20: note: (near initialization for ‘amd_pmc_s2idle_dev_ops’)
>   CC [M]  drivers/staging/iio/impedance-analyzer/ad5933.o
> ../drivers/platform/x86/amd/pmc.c: In function ‘amd_pmc_probe’:
> ../drivers/platform/x86/amd/pmc.c:1070:23: error: implicit declaration of function ‘acpi_register_lps0_dev’; did you mean ‘acpi_register_gsi’? [-Werror=implicit-function-declaration]
>  1070 |                 err = acpi_register_lps0_dev(&amd_pmc_s2idle_dev_ops);
>       |                       ^~~~~~~~~~~~~~~~~~~~~~
>       |                       acpi_register_gsi
>   CC [M]  drivers/staging/rts5208/rtsx_scsi.o
> ../drivers/platform/x86/amd/pmc.c: In function ‘amd_pmc_remove’:
> ../drivers/platform/x86/amd/pmc.c:1091:17: error: implicit declaration of function ‘acpi_unregister_lps0_dev’; did you mean ‘acpi_unregister_gsi’? [-Werror=implicit-function-declaration]
>  1091 |                 acpi_unregister_lps0_dev(&amd_pmc_s2idle_dev_ops);
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~
>       |                 acpi_unregister_gsi
> ../drivers/platform/x86/amd/pmc.c: At top level:
> ../drivers/platform/x86/amd/pmc.c:878:35: error: storage size of ‘amd_pmc_s2idle_dev_ops’ isn’t known
>   878 | static struct acpi_s2idle_dev_ops amd_pmc_s2idle_dev_ops = {
>       |                                   ^~~~~~~~~~~~~~~~~~~~~~
> 
> 
> Full randconfig file is attached.

Shyam, can you look into fixing this please?

Regards,

Hans