linux-kernel - Re: [PATCH] arm64: dts: qcom: qru1000-idp: add SDHCI for emmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 26 Aug 2023 12:26:51 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Komal Bajaj <quic_kbajaj@...cinc.com>, agross@...nel.org,
        andersson@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qru1000-idp: add SDHCI for emmc

On 22.08.2023 13:48, Komal Bajaj wrote:
> Add sdhci node for emmc in qru1000-idp.
> 
> Signed-off-by: Komal Bajaj <quic_kbajaj@...cinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qru1000-idp.dts | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qru1000-idp.dts b/arch/arm64/boot/dts/qcom/qru1000-idp.dts
> index 2a862c83309e..672e1946eba2 100644
> --- a/arch/arm64/boot/dts/qcom/qru1000-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qru1000-idp.dts
> @@ -460,6 +460,29 @@ tenx_sp_mem: tenx-sp-buffer@...000000 {
>  	};
>  };
> 
> +&sdhc {
> +	pinctrl-0 = <&sdc_on_state>;
> +	pinctrl-1 = <&sdc_off_state>;
> +	pinctrl-names = "default", "sleep";
> +
> +	cap-mmc-hw-reset;
Looks like the qcom mmc driver doesn't have any card_hw_reset ops.
Would that be something necessary or valueable for this platform/
device?

Konrad