linux-kernel - Re: [PATCH v2 3/3] ARM: dts: qcom-msm8916-samsung-fortuna: Include dts from arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <024ded8e-d6b9-45dd-9633-03daa403f125@linaro.org>
Date:   Sat, 26 Aug 2023 14:03:42 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     "Lin, Meng-Bo" <linmengbo0689@...tonmail.com>,
        linux-kernel@...r.kernel.org
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Stephan Gerhold <stephan@...hold.net>,
        Nikita Travkin <nikita@...n.ru>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
        Gareth Peoples <mail@...opl.es>
Subject: Re: [PATCH v2 3/3] ARM: dts: qcom-msm8916-samsung-fortuna: Include
 dts from arm64

On 1.08.2023 13:22, Lin, Meng-Bo wrote:
> After adding all necessary support for MSM8916 SMP/cpuidle without PSCI
> on ARM32, build fortunaltezt and heatqlte device trees from the arm64
> tree together with the ARM32 include to allow booting this device on ARM32.
> 
> The approach to include device tree files from other architectures is
> inspired from e.g. the Raspberry Pi (bcm2711-rpi-4-b.dts) where this is
> used to build the device tree for both ARM32 and ARM64.
> 
> [Add workaround to TSENS problem]
> Co-developed-by: Stephan Gerhold <stephan@...hold.net>
> Signed-off-by: Stephan Gerhold <stephan@...hold.net>
> [Add heatqlte]
> Co-developed-by: Gareth Peoples <mail@...opl.es>
> Signed-off-by: Gareth Peoples <mail@...opl.es>
> Signed-off-by: Lin, Meng-Bo <linmengbo0689@...tonmail.com>
> ---
>  arch/arm/boot/dts/qcom-msm8916-samsung-fortunaltezt.dts | 8 ++++++++
>  arch/arm/boot/dts/qcom-msm8916-samsung-heatqlte.dts     | 8 ++++++++
>  arch/arm/boot/dts/qcom/Makefile                         | 2 ++
>  3 files changed, 18 insertions(+)
>  create mode 100644 arch/arm/boot/dts/qcom-msm8916-samsung-fortunaltezt.dts
>  create mode 100644 arch/arm/boot/dts/qcom-msm8916-samsung-heatqlte.dts
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8916-samsung-fortunaltezt.dts b/arch/arm/boot/dts/qcom-msm8916-samsung-fortunaltezt.dts
> new file mode 100644
> index 000000000000..b9704fea7029
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-msm8916-samsung-fortunaltezt.dts
> @@ -0,0 +1,8 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +#include "arm64/qcom/msm8916-samsung-fortunaltezt.dts"
> +#include "qcom-msm8916-smp.dtsi"
> +
> +&tsens {
> +	/* FIXME: The device crashes when accessing the SROT region for some reason */
> +	status = "disabled";
All of SROT, or just e.g. TSENS_EN?

If only the headswitch is inaccessible, you may still reach
the hardware if it's been turned on from bl

Konrad