[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1b15ca0d-0781-c3f8-4822-fce3a7fbb7e7@linaro.org>
Date: Sat, 26 Aug 2023 13:07:36 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Konrad Dybcio <konrad.dybcio@...aro.org>, rfoss@...nel.org,
todor.too@...il.com, agross@...nel.org, andersson@...nel.org,
mchehab@...nel.org, hverkuil-cisco@...all.nl,
laurent.pinchart@...asonboard.com, sakari.ailus@...ux.intel.com,
andrey.konovalov@...aro.org
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 11/15] media: qcom: camss: Functionally decompose
CSIPHY clock lookups
On 26/08/2023 11:12, Konrad Dybcio wrote:
>> - csiphy->rate_set[i] = true;
>> + for (k = 0; k < camss->res->csiphy_num; k++) {
>> + csiphy->rate_set[i] = csiphy_match_clock_name(clock->name,
>> + "csiphy%d_timer", k);
> This entire functions is like.. soooo over-engineered
I'm going to accept your compliment there.
> adding something like csiphy_timer_clks and cisphy_clks and stuff
> would make this string comparison mess unnecessary
I don't understand your comment.
Having a litany of static comparisons is definitely inferior to a
generic helper function.
I'm not sure what you are asking/arguing for here.
---
bod
Powered by blists - more mailing lists