linux-kernel - Re: [PATCH v3 11/15] media: qcom: camss: Functionally decompose CSIPHY clock lookups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0acf952f-edd4-4f62-8b07-0fe727526d96@linaro.org>
Date:   Sat, 26 Aug 2023 14:11:24 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>, rfoss@...nel.org,
        todor.too@...il.com, agross@...nel.org, andersson@...nel.org,
        mchehab@...nel.org, hverkuil-cisco@...all.nl,
        laurent.pinchart@...asonboard.com, sakari.ailus@...ux.intel.com,
        andrey.konovalov@...aro.org
Cc:     linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 11/15] media: qcom: camss: Functionally decompose
 CSIPHY clock lookups

On 26.08.2023 14:07, Bryan O'Donoghue wrote:
> On 26/08/2023 11:12, Konrad Dybcio wrote:
>>> -            csiphy->rate_set[i] = true;
>>> +        for (k = 0; k < camss->res->csiphy_num; k++) {
>>> +            csiphy->rate_set[i] = csiphy_match_clock_name(clock->name,
>>> +                                      "csiphy%d_timer", k);
>> This entire functions is like.. soooo over-engineered
> 
> I'm going to accept your compliment there.
> 
> 
>> adding something like csiphy_timer_clks and cisphy_clks and stuff
>> would make this string comparison mess unnecessary
> 
> I don't understand your comment.
> 
> Having a litany of static comparisons is definitely inferior to a generic helper function.

portray this

struct camss_whatever_it_was_called {
	struct clk_bulk_data *csiphy_clks;
	struct clk_bulk_data *csiphy_timer_clks;
	[...]
}

and then

clk_bulk_prepare_enable(csiphy_clks)

etc

instead of weird looping and matching

Konrad