linux-kernel - [PATCH] staging: rtl8192e: Remove unsupported mode IW_MODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20230827132704.GA12506@matrix-ESPRIMO-P710>
Date:   Sun, 27 Aug 2023 15:27:04 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: [PATCH] staging: rtl8192e: Remove unsupported mode IW_MODE_ADHOC

Remove unsupported mode IW_MODE_ADHOC because this mode is only partially
coded in the driver.

rtllib_rx_mgt() can only handle probe requests in IW_MODE_ADHOC and no
authentication or association frames.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@...il.com>
---
The only feature that is partially working in IW_MODE_ADHOC mode are
beacons. Older Android Smartphones can see the beacons but Ubuntu 22.04
and Windows 11 not. No Device is able to connect.

Debug code shows that only frames with ff:ff:ff:ff:ff:ff in addr1 field
reach rtllib_rx_InfraAdhoc() when in IW_MODE_ADHOC mode.

Using wireshark to monitor packets shows beacons and probe requests and
probe responses but no further traffic.

When this patch is accepted approximately 600 lines of code can be
removed from the driver.

Tested with rtl8192e (WLL6130-D99) in Mode n (12.5 MB/s)
Transferred this patch over wlan connection of rtl8192e.
---
 drivers/staging/rtl8192e/rtllib_softmac_wx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
index 0b690f0ffeef..48703d93df30 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
@@ -258,7 +258,6 @@ int rtllib_wx_set_mode(struct rtllib_device *ieee, struct iw_request_info *a,
 	mutex_lock(&ieee->wx_mutex);
 	switch (wrqu->mode) {
 	case IW_MODE_MONITOR:
-	case IW_MODE_ADHOC:
 	case IW_MODE_INFRA:
 		break;
 	case IW_MODE_AUTO:
-- 
2.41.0