[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANBLGcyfxNSgNjNvU1_N2ZC5q1YjqDjS69E7grbfCYM7bmm=-g@mail.gmail.com>
Date: Sun, 27 Aug 2023 19:35:41 +0200
From: Emil Renner Berthing <kernel@...il.dk>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Jisheng Zhang <jszhang@...nel.org>,
Samin Guo <samin.guo@...rfivetech.com>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: stmmac: dwmac-starfive: improve error
handling during probe
On Sun, 27 Aug 2023 at 15:59, Russell King (Oracle)
<linux@...linux.org.uk> wrote:
> On Sun, Aug 27, 2023 at 09:41:49PM +0800, Jisheng Zhang wrote:
> > After stmmac_probe_config_dt() succeeds, when error happens later,
> > stmmac_remove_config_dt() needs to be called for proper error handling.
>
> Have you thought about converting to use devm_stmmac_probe_config_dt()
> which will call stmmac_remove_config_dt() if the probe fails or when
> the device is unbound?
+1. Using devm_stmmac_probe_config_dt() seems like a better solution.
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists