linux-kernel - Re: [PATCH 1/1] media: ivsc: Depend on VIDEO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59917723-6db4-8e81-88d9-b4c124914473@infradead.org>
Date:   Mon, 28 Aug 2023 12:15:49 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        linux-media@...r.kernel.org
Cc:     Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Wentong Wu <wentong.wu@...el.com>
Subject: Re: [PATCH 1/1] media: ivsc: Depend on VIDEO_DEV

Hi,

On 8/28/23 01:57, Sakari Ailus wrote:
> CONFIG_VIDEO_DEV is required by other selected symbols. Depend on it.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Fixes: 29006e196a56 ("media: pci: intel: ivsc: Add CSI submodule")
> Signed-off-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>
Tested-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/media/pci/intel/ivsc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/pci/intel/ivsc/Kconfig b/drivers/media/pci/intel/ivsc/Kconfig
> index e9ecd0bd99bd..0acea4678fc0 100644
> --- a/drivers/media/pci/intel/ivsc/Kconfig
> +++ b/drivers/media/pci/intel/ivsc/Kconfig
> @@ -3,7 +3,7 @@
>  
>  config INTEL_VSC
>  	tristate "Intel Visual Sensing Controller"
> -	depends on INTEL_MEI && ACPI
> +	depends on INTEL_MEI && ACPI && VIDEO_DEV
>  	select MEDIA_CONTROLLER
>  	select VIDEO_V4L2_SUBDEV_API
>  	select V4L2_ASYNC

-- 
~Randy