linux-kernel - Re: [PATCH v4 2/3] dt-bindings: usb: snps,dwc3: Add runtime-suspend-on-usb-suspend property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <969988f6-f01f-0e31-6a98-7d02c5a3a4ad@quicinc.com>
Date:   Mon, 28 Aug 2023 14:34:31 -0700
From:   Elson Serrao <quic_eserrao@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        Roger Quadros <rogerq@...nel.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: [PATCH v4 2/3] dt-bindings: usb: snps,dwc3: Add
 runtime-suspend-on-usb-suspend property



On 8/26/2023 1:39 AM, Krzysztof Kozlowski wrote:
> On 26/08/2023 03:53, Thinh Nguyen wrote:
>>>>> For example on Qualcomm platforms there is a phy sideband signalling
>>>>> which detects the wakeup signal when resume is initiated by the host.
>>>>
>>>> So compatible-specific.
>>>>
>>>>> Thus qcom platforms can benefit from this feature by defining this dt
>>>>> property. (in a parallel discussion with Thinh N to come up with a
>>>>> better name for this dt entry).
>>>>
>>>> Thanks, with quite a long message you at the end admitted this is
>>>> compatible-specific. Exactly what I wrote it one sentence previously.
>>>>
>>
>> Various dwc3 platforms often share a common capability that can be
>> shared with a common dt property. If we dedicate a property such as in
>> this case, it helps designers enable a certain feature without updating
>> the driver every time a new platform is introduced. It also helps keep
>> the driver a bit simpler on the compatible checks.
> 
> That's not the purpose of bindings. Sorry.
> 
>>
>> Regardless, what Krzysztof said is valid. Perhaps we can look into
>> enhancing dwc3 to maintain shared behavior based on compatible instead?
> 
> 
Thank you Krzysztof, Thinh, Roger for your comments and feedback. I will 
upload v5 making this change compatible-specifc.

Best Regards
Elson