linux-kernel - Re: [PATCH] cpufreq: powernow-k8: Use related

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 28 Aug 2023 12:27:41 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Liao Chang <liaochang1@...wei.com>
Cc:     rafael@...nel.org, srivatsa.bhat@...ux.vnet.ibm.com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: powernow-k8: Use related_cpus instead of cpus
 in driver.exit()

On 26-08-23, 09:51, Liao Chang wrote:
> Since the 'cpus' field of policy structure will become empty in the
> cpufreq core API, it is better to use 'related_cpus' in the exit()
> callback of driver.
> 
> Fixes: c3274763bfc3 ("cpufreq: powernow-k8: Initialize per-cpu data-structures properly")
> Signed-off-by: Liao Chang <liaochang1@...wei.com>
> ---
>  drivers/cpufreq/powernow-k8.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
> index d289036beff2..b10f7a1b77f1 100644
> --- a/drivers/cpufreq/powernow-k8.c
> +++ b/drivers/cpufreq/powernow-k8.c
> @@ -1101,7 +1101,8 @@ static int powernowk8_cpu_exit(struct cpufreq_policy *pol)
>  
>  	kfree(data->powernow_table);
>  	kfree(data);
> -	for_each_cpu(cpu, pol->cpus)
> +	/* pol->cpus will be empty here, use related_cpus instead. */
> +	for_each_cpu(cpu, pol->related_cpus)
>  		per_cpu(powernow_data, cpu) = NULL;
>  
>  	return 0;

Applied. Thanks.

-- 
viresh