linux-kernel - RE: [EXT] Re: [PATCH v4 1/1] wifi: mwifiex: added code to support host mlme.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PA4PR04MB9638EAED5E4361F0429A796CD1E0A@PA4PR04MB9638.eurprd04.prod.outlook.com>
Date:   Mon, 28 Aug 2023 09:30:08 +0000
From:   David Lin <yu-hao.lin@....com>
To:     Francesco Dolcini <francesco@...cini.it>
CC:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sharvari Harisangam <sharvari.harisangam@....com>,
        Pete Hsieh <tsung-hsien.hsieh@....com>,
        "kvalo@...nel.org" <kvalo@...nel.org>,
        "amitkarwar@...il.com" <amitkarwar@...il.com>,
        "ganapathi017@...il.com" <ganapathi017@...il.com>,
        "huxinming820@...il.com" <huxinming820@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>
Subject: RE: [EXT] Re: [PATCH v4 1/1] wifi: mwifiex: added code to support
 host mlme.

> From: Francesco Dolcini <francesco@...cini.it>
> Sent: Friday, August 25, 2023 6:04 PM
> To: David Lin <yu-hao.lin@....com>
> Cc: linux-wireless@...r.kernel.org; linux-kernel@...r.kernel.org; Sharvari
> Harisangam <sharvari.harisangam@....com>; Pete Hsieh
> <tsung-hsien.hsieh@....com>; kvalo@...nel.org; amitkarwar@...il.com;
> ganapathi017@...il.com; huxinming820@...il.com;
> davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com
> Subject: [EXT] Re: [PATCH v4 1/1] wifi: mwifiex: added code to support host
> mlme.
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> Hello David,
> thanks for your patch.
> 
> On Tue, Aug 15, 2023 at 07:09:25AM +0000, David Lin wrote:
> > 1. For station mode first.
> > 2. This feature is a must for WPA3.
> > 3. Firmware key api version 2 is needed for this feature.
> > 4. The code is only enabled and tested with IW416.
> > 5. This feature is disabled for other chips.
> >
> > Signed-off-by: David Lin <yu-hao.lin@....com>
> 
> I think you are missing a few of the comments you received so far.
> 
>  - verify the recipient list, the list here was likely generated with an
>    old kernel tree using an outdated MAINTAINERS file

I followed your suggestion and issued the command on latest wireless test repository.

>  - you need to provide a changelog in your patch, otherwise is not
>    possible for other to review

Yes, one the cover page.

>  - some concern were raised on the fact that this is tested only with
>    IW416, we should have some confidence this is not creating regressions.
> 

I had tested IW416 without host mlme enabled, it can work without issues.

BTW, The state of PATCH v4 is changed to "Defered".
Link to latest PATCH v4:
https://patchwork.kernel.org/project/linux-wireless/patch/PA4PR04MB963838F12BADC1B9FD377CB7D114A@PA4PR04MB9638.eurprd04.prod.outlook.com/

Press "expand" of Series, you can find <v4 0/1> which is the cover letter with change history of PATCH v2 to v4.
> 
> Francesco