linux-kernel - Re: [PATCH 1/2] irqchip/qcom-pdc: don't read version register if it is not available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <76b29f8b-9106-4436-a816-926b016f667f@linaro.org>
Date:   Mon, 28 Aug 2023 11:45:54 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     "Maulik Shah (mkshah)" <quic_mkshah@...cinc.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH 1/2] irqchip/qcom-pdc: don't read version register if it
 is not available

On 28.08.2023 11:36, Maulik Shah (mkshah) wrote:
> Hi Dmitry,
> 
> This patch may be useful if there was a case where some PDCs don't have version register populated/available,
> In all PDC versions, version register is always available but due to reg size not good enough in device tree for SM8150 it failed to read.
> 
> reg size in device node must be expanded if its too small to access all registers and i think
> additional check in driver to check if size is good enough would not be of much use.
The devicetree change has already been commited and not taking care
of this on the driver side would break backwards compatibility with
devicetrees without this change.


Konrad