linux-kernel - Re: [PATCH v3] usb: typec: qcom: check regulator enable status before disabling it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a69b3d5-66bd-4085-8b36-2972b06e0a0a@linaro.org>
Date:   Mon, 28 Aug 2023 11:50:29 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     quic_huliu@...cinc.com,
        Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-arm-msm@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, quic_fenglinw@...cinc.com,
        subbaram@...cinc.com
Subject: Re: [PATCH v3] usb: typec: qcom: check regulator enable status before
 disabling it

On 28.08.2023 07:16, Hui Liu via B4 Relay wrote:
> From: Hui Liu <quic_huliu@...cinc.com>
> 
> Check regulator enable status before disabling it to avoid
> unbalanced regulator disable warnings.
> 
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> Acked-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> Signed-off-by: Hui Liu <quic_huliu@...cinc.com>
> ---
> Changes in v3:
> - Take Bryan's proposal to remove enable/disable operation in pdphy
> enable and pdphy disable function, then enable regulator in pdphy start
> function and disable it in pdphy stop function.
The commit message makes no sense now, it should have been updated
to reflect what you're doing after the logic had changed.

Konrad