linux-kernel - Re: [PATCH v2 1/2] crypto: qat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZOx6+i5HEAY4F4X3@smile.fi.intel.com>
Date:   Mon, 28 Aug 2023 13:46:18 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Lucas Segarra Fernandez <lucas.segarra.fernandez@...el.com>,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        qat-linux@...el.com, alx@...nel.org,
        Giovanni Cabiddu <giovanni.cabiddu@...el.com>
Subject: Re: [PATCH v2 1/2] crypto: qat - refactor included headers

On Mon, Aug 28, 2023 at 06:22:00PM +0800, Herbert Xu wrote:
> On Fri, Aug 25, 2023 at 03:37:53PM +0300, Andy Shevchenko wrote:
> >
> > Why?
> 
> Because we shouldn't be including every single header file that
> kernel.h includes individually.

kernel.h is misleading here. It includes 98% of something which this file is
not using or going to use. Can you tell _why_ we need that 98% bulk to be
included here?

-- 
With Best Regards,
Andy Shevchenko