linux-kernel - Re: [PATCH v2 1/2] RDMA/rxe: Improve newline in printing messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fs43cudc.fsf@jogness.linutronix.de>
Date:   Mon, 28 Aug 2023 12:57:43 +0206
From:   John Ogness <john.ogness@...utronix.de>
To:     Zhu Yanjun <zyjzyj2000@...il.com>
Cc:     Zhu Yanjun <yanjun.zhu@...ux.dev>,
        Li Zhijian <lizhijian@...itsu.com>, linux-rdma@...r.kernel.org,
        "pmladek@...e.com" <pmladek@...e.com>,
        "senozhatsky@...omium.org" <senozhatsky@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>, jgg@...pe.ca,
        leon@...nel.org, linux-kernel@...r.kernel.org,
        rpearsonhpe@...il.com,
        Daisuke Matsuda <matsuda-daisuke@...itsu.com>
Subject: Re: [PATCH v2 1/2] RDMA/rxe: Improve newline in printing messages

On 2023-08-28, Zhu Yanjun <zyjzyj2000@...il.com> wrote:
> Do you mean "a newline can help flushing messages out"?
> That is, in printk, the message will be buffered until it is full or
> it meets a newline?

Correct. A trailing newline is needed for the record to become
"finalized". Only finalized records are pushed out to consoles.

If there is no trailing newline, the message will be buffered until
printk is called using a message with a trailing newline.

There are some other reasons why it may be flushed. But for sure the
flushing will be delayed if there is no trailing newline.

John Ogness