linux-kernel - Re: [PATCH 1/2] Simplify sysrq help

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023082831-undefined-hut-11fd@gregkh>
Date:   Mon, 28 Aug 2023 12:51:38 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Andras Sebok <sebokandris2009@...il.com>
Cc:     linux-serial@...r.kernel.org, andriseseboke@...il.com,
        linux-kernel@...r.kernel.org, jirislaby@...nel.org
Subject: Re: [PATCH 1/2] Simplify sysrq help

On Mon, Aug 28, 2023 at 12:27:53PM +0200, Andras Sebok wrote:
> This patch simplyfies sysrq help menu by moving each command to a 
> separate line and by moving the key from brackets to after a semicolon.
> 
> before:
> sysrq: HELP : loglevel(0-9) reboot(b) crash(c) terminate-all-tasks(e) memory-full-oom-kill(f) kill-all-tasks(i) thaw-filesystems(j) sak(k) show-backtrace-all-active-cpus(l) show-memory-usage(m) nice-all-RT-tasks(n) poweroff(o) show-registers(p) show-all-timers(q) unraw(r) sync(s) show-task-states(t) unmount(u) force-fb(v) show-blocked-tasks(w) dump-ftrace-buffer(z)
> 
> after:
> sysrq: HELP :
> loglevel : 0-9
> reboot : b
> crash : c
> terminate-all-tasks : e
> memory-full-oom-kill : f
> kill-all-tasks : i
> thaw-filesystems : j
> sak : k
> show-backtrace-all-active-cpus : l
> show-memory-usage : m
> nice-all-RT-tasks : n
> poweroff : o
> show-registers : p
> show-all-timers : q
> unraw : r
> sync : s
> show-task-states : t
> unmount : u
> force-fb : v
> show-blocked-tasks : w
> dump-ftrace-buffer : z

So now the options all scroll off the screen?  Are you sure this is
wise?  What problem are you trying to solve here, it just looks like you
are changing one "help text format for another", and doesn't actually
change much of anything.

Note the:
	sysrq: HELP :

line format being different from all the others makes this not even look
correct?

So I really do not see the point of this change here, why is it needed?

thanks,

greg k-h