linux-kernel - Re: [PATCH] media: i2c: rdacm2: Remove an incorrect fwnode_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230828105723.GF14596@pendragon.ideasonboard.com>
Date:   Mon, 28 Aug 2023 13:57:23 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Jacopo Mondi <jacopo.mondi@...asonboard.com>
Cc:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Jacopo Mondi <jacopo+renesas@...ndi.org>,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-media@...r.kernel.org
Subject: Re: [PATCH] media: i2c: rdacm2: Remove an incorrect
 fwnode_handle_put() call

On Mon, Aug 28, 2023 at 09:48:10AM +0200, Jacopo Mondi wrote:
> Hi Christophe
> 
> On Sat, Aug 26, 2023 at 10:05:06AM +0200, Christophe JAILLET wrote:
> > The commit in Fixes has removed an fwnode_handle_put() call in the error
> > handling path of the probe.
> >
> > Remove the same call from the remove function.
> >
> > Fixes: 1029939b3782 ("media: v4l: async: Simplify async sub-device fwnode matching")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> 
> Reviewed-by: Jacopo Mondi <jacopo.mondi@...asonboard.com>

The subject line should read "rdacm21", not "rdacm2". with that fixed,

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>

> > ---
> > /!\   This patch is highly speculative. Review with care.   /!\
> >
> > If it is correct, it is likely that other similar issue lurk in commit
> > 1029939b3782. I've not looked in detail and my cocci script did not
> > trigger on them but drivers/media/i2c/max9286.c also looks like a
> > similar candidate.
> 
> I think the call to  fwnode_handle_put(priv->sd.fwnode) in
> max9286_v4l2_unregister() can indeed be removed, yes!

I agree.

> > ---
> >  drivers/media/i2c/rdacm21.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c
> > index a36a709243fd..3e22df36354f 100644
> > --- a/drivers/media/i2c/rdacm21.c
> > +++ b/drivers/media/i2c/rdacm21.c
> > @@ -608,7 +608,6 @@ static void rdacm21_remove(struct i2c_client *client)
> >  	v4l2_async_unregister_subdev(&dev->sd);
> >  	v4l2_ctrl_handler_free(&dev->ctrls);
> >  	i2c_unregister_device(dev->isp);
> > -	fwnode_handle_put(dev->sd.fwnode);
> >  }
> >
> >  static const struct of_device_id rdacm21_of_ids[] = {

-- 
Regards,

Laurent Pinchart