linux-kernel - Re: [PATCH] vfs: use helpers for calling f_op->{read,write}_iter() in read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3283678e-1855-ed05-a9f2-44935bb806df@huaweicloud.com>
Date:   Mon, 28 Aug 2023 20:17:52 +0800
From:   Kemeng Shi <shikemeng@...weicloud.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     viro@...iv.linux.org.uk, brauner@...nel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfs: use helpers for calling f_op->{read,write}_iter() in
 read_write.c

on 8/28/2023 8:00 PM, Christoph Hellwig wrote:
> On Mon, Aug 28, 2023 at 11:50:56PM +0800, Kemeng Shi wrote:
>> use helpers for calling f_op->{read,write}_iter() in read_write.c
>>
> 
> Why?  We really should just remove the completely pointless wrappers
> instead.
> 
This patch is intended to uniform how we call {read,write}_iter()...
Would it be good to opencode all call_{read,write}_iter. But I'm not sure
if these wrappers are really needless...